[libvirt] [PATCH] maint: remove redundant tests after virStrToLong

Matthias Bolte matthias.bolte at googlemail.com
Wed Mar 31 13:40:01 UTC 2010


2010/3/30 Eric Blake <eblake at redhat.com>:
> virStrToLong* guarantees (via strtol) that the end pointer will be set
> to the point at which parsing stopped (even on failure, this point is
> the start of the input string).
>
> * src/esx/esx_driver.c (esxGetVersion): Remove pointless
> conditional.
> * src/qemu/qemu_conf.c (qemuParseCommandLinePCI)
> (qemuParseCommandLineUSB, qemuParseCommandLineSmp): Likewise.
> * src/qemu/qemu_monitor_text.c
> (qemuMonitorTextGetMigrationStatus): Likewise.
> ---
>  src/esx/esx_driver.c         |    6 ++----
>  src/qemu/qemu_conf.c         |   14 ++++++--------
>  src/qemu/qemu_monitor_text.c |    6 +++---
>  3 files changed, 11 insertions(+), 15 deletions(-)
>

ACK.

Matthias




More information about the libvir-list mailing list