[libvirt] [PATCH] mingw: Fix symbol export

[Matthias Bolte]

2010/5/3 Eric Blake <eblake at redhat.com>:
> On 05/03/2010 12:55 PM, Matthias Bolte wrote:
>> In commit 98fb83ce25f46e0236706fa6e0943032d921935f I changed the
>> version script handling. But it seems that I didn't test this properly
>> and broke it. The .def file is passed to the compiler directly, but it
>> should get passed to the linker instead.
>>
>> Set VERSION_SCRIPT_FLAGS to -Wl, to pass the .def file correctly to
>> the linker.
>>
>> This fixes the undefined symbol errors while linking virsh.
>
> ACK.

Thanks, pushed.

>
> I'm still getting some other errors using autobuild.sh, but they are
> independent of this one and shouldn't hold up this one from going in:

I never used autobuild.sh, but it shouldn't do any thing different
than a manual build.

>  CCLD   libvirt.la
> Info: resolving _xmlFree by linking to __imp__xmlFree (auto-import)
> Creating library file: .libs/libvirt.dll.a
> /usr/lib/gcc/i686-pc-mingw32/4.4.1/../../../../i686-pc-mingw32/bin/ld:
> warning: auto-importing has been activated without --enable-auto-import
> specified on the command line.
> This should work unless it involves constant data structures referencing
> symbols from auto-imported DLLs.
> Cannot export linuxDomainInterfaceStats: symbol not defined
> Cannot export virCondWaitUntil: symbol not defined
> Cannot export virPipeReadUntilEOF: symbol not defined

I know of this two symbols (virCondWaitUntil and virPipeReadUntilEOF)
and am right now preparing a patch to fix that. Previously I just
removed virCondWaitUntil and virPipeReadUntilEOF from the symbol
files.

> Cannot export xenLinuxDomainBlockStats: symbol not defined
> collect2: ld returned 1 exit status
>

I never had problems with the other two symbols:
linuxDomainInterfaceStats and xenLinuxDomainBlockStats

I build directly on Windows instead of cross-compiling from Fedora,
maybe that makes a difference.

Matthias