[libvirt] [TCK PATCH] block devices: allow specification of size for safety

Jim Meyering jim at meyering.net
Wed May 5 19:20:28 UTC 2010


Dave Allan wrote:

> On Wed, May 05, 2010 at 08:54:35PM +0200, Jim Meyering wrote:
>> Eric Blake wrote:
>> > I was getting failures of domain/103-blockdev-save-restore.t when
>> > connecting as qemu:///session, since my uid could stat /dev/sdb
>> > but not open it.  That test now skips for unprivileged users, as well
>> > as adds a layer of sanity checking against expected size to avoid
>> > trashing the wrong device.
>
> Can we provide the option to specify the device serial number so that
> it's really impossible to trash the wrong device?

Good point.
That would be even better.




More information about the libvir-list mailing list