[libvirt] [PATCH] build: use LIBADD, not LDFLAGS, for adding libraries

Jim Meyering jim at meyering.net
Fri May 7 17:39:04 UTC 2010


Eric Blake wrote:
> On 05/07/2010 11:18 AM, Jim Meyering wrote:
>>> @@ -686,7 +692,8 @@ endif
>>>  libvirt_driver_secret_la_CFLAGS = \
>>>  		-I at top_srcdir@/src/conf
>>>  if WITH_DRIVER_MODULES
>>> -libvirt_driver_secret_la_LDFLAGS = -module -avoid-version ../gnulib/lib/libgnu.la
>>> +libvirt_driver_secret_la_LDFLAGS = -module -avoid-version
>>> +libvirt_driver_secret_la_LDAD = ../gnulib/lib/libgnu.la
>>
>> Oops.  That should be ..._LDADD
>
> Or better, LIBADD.  Automake didn't warn about the typo, because it
> wasn't a primitive, but it did warn about LDADD.  Fixed.

Hah.  Yes ;-)




More information about the libvir-list mailing list