[libvirt] locking down struct size/layout in remote-protocol.x

Jim Meyering jim at meyering.net
Mon May 10 20:36:46 UTC 2010


Eric Blake wrote:
> On 05/07/2010 03:23 PM, Jim Meyering wrote:
>> +remote_protocol-structs:
>> +	$(AM_V_GEN)if pdwtags --help > /dev/null 2>&1; then		\
>
> Some shells (at least Solaris /bin/sh) are noisy in spite of the
> redirections, when a program doesn't exist.  I'm proposing a followup
> patch to clean up this invocation to use a subshell, and also to fix the
> subshell for cppi in cfg.mk.

Or you could consider the noise a two-pronged feature:
  - notify user that their $(SHELL) is inferior
  - more noise about lack of a useful developer tool (pdwtags or cppi)




More information about the libvir-list mailing list