[libvirt] [PATCH] tests: correct PATH in new test, for when running manually

Eric Blake eblake at redhat.com
Tue May 11 15:55:10 UTC 2010


On 05/11/2010 09:45 AM, Jim Meyering wrote:
> I'd prepended a *file* to PATH, not the containing directory.
> The bug would have shown up only when running this test manually.
> 
> 
> -# If $abs_top_builddir/tools/virsh is not early in $PATH, put it there,
> +# If $abs_top_builddir/tools is not early in $PATH, put it there,
>  # so that we can safely invoke "virsh" simply with its name.
>  case $PATH in
> -  $abs_top_builddir/tools/src:$abs_top_builddir/tools/virsh:*) ;;
> -  $abs_top_builddir/tools/virsh:*) ;;
> -  *) PATH=$abs_top_builddir/tools/virsh:$PATH; export PATH ;;
> +  $abs_top_builddir/tools/src:$abs_top_builddir/tools:*) ;;
> +  $abs_top_builddir/tools:*) ;;
> +  *) PATH=$abs_top_builddir/tools:$PATH; export PATH ;;

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100511/d06abc79/attachment-0001.sig>


More information about the libvir-list mailing list