[libvirt] [PATCH] Fix NULL dereference in remoteDomainMigratePrepare2

jdenemar at redhat.com jdenemar at redhat.com
Wed May 12 14:53:13 UTC 2010


From: Jiri Denemark <jdenemar at redhat.com>

---
 src/remote/remote_driver.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 990bfce..c62e3d6 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -2849,8 +2849,12 @@ remoteDomainMigratePrepare2 (virConnectPtr dconn,
         goto done;
 
     if (ret.cookie.cookie_len > 0) {
-        *cookie = ret.cookie.cookie_val; /* Caller frees. */
-        *cookielen = ret.cookie.cookie_len;
+        if (cookie && cookielen) {
+            *cookie = ret.cookie.cookie_val; /* Caller frees. */
+            *cookielen = ret.cookie.cookie_len;
+        } else {
+            VIR_FREE(ret.cookie.cookie_val);
+        }
     }
     if (ret.uri_out)
         *uri_out = *ret.uri_out; /* Caller frees. */
-- 
1.7.1




More information about the libvir-list mailing list