[libvirt] [PATCHv2 0/10+] error message cleanup

Eric Blake eblake at redhat.com
Thu May 13 01:08:44 UTC 2010


I've done some more work on error cleanup, expanding 3 patches
of v1 into 10 patches, with more still to be written.  See
individual patches for more comments.

 bootstrap.conf                |    1 +
 cfg.mk                        |    5 +-
 src/datatypes.c               |  127 +++++++++++----
 src/libvirt.c                 |   94 ++++++-----
 src/security/virt-aa-helper.c |  141 ++++++++--------
 src/storage/storage_backend.c |    2 +-
 src/util/virterror.c          |  374 +++++++++++++---------------------------
 src/xen/xend_internal.c       |    5 +-
 tests/cpuset                  |    4 +-
 tests/undefine                |    4 +-
 10 files changed, 352 insertions(+), 405 deletions(-)

Net reduction in lines of code is a good thing.

 [PATCHv2 01/10] virt-aa-helper: translate error messages
 [PATCHv2 02/10] build: use gnulib func module
 [PATCHv2 03/10] datatypes: avoid redundant __FUNCTION__
 [PATCHv2 04/10] virErrorMsg: refactor to simplify common case
 [PATCHv2 05/10] virterror: start messages with lower case
 [PATCHv2 06/10] virterror: clean up VIR_ERR_HTTP_ERROR usage
 [PATCHv2 07/10] virterror: clean up VIR_ERR_XML_DETAIL usage
 [PATCHv2 08/10] virterror: clean up several seldom-used errors
 [PATCHv2 09/10] virterror: clean up VIR_ERR_INVALID_NETWORK usage
 [PATCHv2 10/10] virterror: clean up VIR_ERR_INVALID_INTERFACE usage
 [PATCHv2 N/N] to be written, after feedback on this round




More information about the libvir-list mailing list