[libvirt] [PATCH] umlAutostartDomain: avoid NULL-deref upon virGetLastError failure

Jim Meyering jim at meyering.net
Mon May 17 12:38:34 UTC 2010


Another...

>From 09579adb73f04c5b940ad28cdfc242cff0726e0e Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering at redhat.com>
Date: Mon, 17 May 2010 14:38:14 +0200
Subject: [PATCH] umlAutostartDomain: avoid NULL-deref upon virGetLastError failure

* src/uml/uml_driver.c (umlAutostartDomain): Handle a NULL return
from virGetLastError.
---
 src/uml/uml_driver.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c
index 63fe808..ffb87c8 100644
--- a/src/uml/uml_driver.c
+++ b/src/uml/uml_driver.c
@@ -157,7 +157,7 @@ umlAutostartDomain(void *payload, const char *name ATTRIBUTE_UNUSED, void *opaqu
         if (umlStartVMDaemon(data->conn, data->driver, vm) < 0) {
             virErrorPtr err = virGetLastError();
             VIR_ERROR(_("Failed to autostart VM '%s': %s"),
-                      vm->def->name, err->message);
+                      vm->def->name, err ? err->message : "");
         }
     }
     virDomainObjUnlock(vm);
--
1.7.1.250.g7d1e8




More information about the libvir-list mailing list