[libvirt] [PATCH] qemudDomainSetVcpus: avoid NULL-deref on failed uuid look-up
Eric Blake
eblake at redhat.com
Mon May 17 17:44:15 UTC 2010
On 05/17/2010 11:33 AM, Jim Meyering wrote:
> Here's the fix, followed by the endjob/cleanup code:
>
>>From d696f6067d6e802714adbf3e36bf53c9fcf3ec76 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering at redhat.com>
> Date: Mon, 17 May 2010 19:28:44 +0200
> Subject: [PATCH] qemudDomainSetVcpus: avoid NULL-deref on failed uuid look-up
>
> * src/qemu/qemu_driver.c (qemudDomainSetVcpus): Upon look-up failure,
> i.e., vm==NULL, goto cleanup, rather than to "endjob", superficially
> since the latter would dereference vm, but more fundamentally because
> we certainly don't want to call qemuDomainObjEndJob before we've
> even attempted qemuDomainObjBeginJob.
ACK.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100517/04a781bb/attachment-0001.sig>
More information about the libvir-list
mailing list