[libvirt] [PATCH] tests: Skip daemon-conf test if dir exceeds UNIX_PATH_MAX

Eric Blake eblake at redhat.com
Mon May 17 18:25:58 UTC 2010


On 05/17/2010 11:29 AM, Eric Blake wrote:
>> +if test ${#SOCKPATH} -lt 108 ; then
> 
> Bash-ism.  To be portable, you'd have to use something like:
> 
> if test `echo "$SOCKPATH" | wc -c` -lt 108; then

Huh, I stand (partially) corrected.  POSIX requires support for ${#foo}.
 If we were to use gnulib's init.sh, we would then have the guarantee
that we have enough of a POSIX environment to rely on that particular
construct.  But right now, test-lib.sh doesn't quite guarantee
everything provided in gnulib.

Jim, is it time to modify test-lib.sh to borrow more ideas from gnulib's
init.sh?

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100517/f4be3d1d/attachment-0001.sig>


More information about the libvir-list mailing list