[libvirt] just pushed 2 more ACK'd patches from yesterday

Jim Meyering jim at meyering.net
Wed May 19 15:11:03 UTC 2010


commit dcf30d9c25daabe722c5298f0a90d562b7e9f7d7
Author: Jim Meyering <meyering at redhat.com>
Date:   Tue May 18 07:53:31 2010 +0200

    initialize "meta" in virStorageFileGetMetadata, not in each caller

    Do not require each caller of virStorageFileGetMetadata and
    virStorageFileGetMetadataFromFD to first clear the storage of the
    "meta" buffer.  Instead, initialize that storage in
    virStorageFileGetMetadataFromFD.
    * src/util/storage_file.c (virStorageFileGetMetadataFromFD): Clear
    "meta" here, not before each of the following callers.
    * src/qemu/qemu_driver.c (qemuSetupDiskCgroup): Don't clear "meta" here.
    (qemuTeardownDiskCgroup): Likewise.
    * src/qemu/qemu_security_dac.c (qemuSecurityDACSetSecurityImageLabel):
    Likewise.
    * src/security/security_selinux.c (SELinuxSetSecurityImageLabel):
    Likewise.
    * src/security/virt-aa-helper.c (get_files): Likewise.

commit e638a2461d082e01df83b08792801e6784f30b9a
Author: Jim Meyering <meyering at redhat.com>
Date:   Mon May 17 22:50:21 2010 +0200

    (qemu*DiskCgroup): avoid dead code

    * src/qemu/qemu_driver.c (qemuTeardownDiskCgroup): Remove
    bogus empty-body while-loop.
    (qemuSetupDiskCgroup): Likewise.




More information about the libvir-list mailing list