[libvirt] [PATCH] dots should be valid characters in interface names

Charles Duffy Charles_Duffy at messageone.com
Thu May 20 02:41:15 UTC 2010


Howdy!

I spent some time scratching my head this evening, as libvirt was 
stripping the target/@dev entry from my interface[@type='ethernet'].

Turns out that this was caused by the interface name containing a 
period, which is rejected by isValidIfname(). As the kernel allows the 
creation of such interfaces, it is improper for libvirt to reject them.

The attached one-liner (built against RHEL6b1's libvirt but still 
applicable against current master as of 10c681622) fixes this issue.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt-0.8.1-allow_dots_in_ifnames.patch
Type: text/x-patch
Size: 432 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100519/907d20ae/attachment-0001.bin>


More information about the libvir-list mailing list