[libvirt] [PATCH] Remove isValidIfname.

Eric Blake eblake at redhat.com
Thu May 20 21:30:21 UTC 2010


On 05/20/2010 01:57 PM, Chris Lalancette wrote:
> We shouldn't be checking validity in domain_conf, since
> it can be used by multiple different hosts and hypervisors.
> Remove the check completely.
> 
>  
> -static bool
> -isValidIfname(const char *ifname) {
> -    return ifname[strspn(ifname, VALID_IFNAME_CHARS)] == 0;
> -}

Conditional ACK - you also need to nuke the (now unused) definition of
VALID_IFNAME_CHARS in domain_conf.h before pushing.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100520/8dccd394/attachment-0001.sig>


More information about the libvir-list mailing list