[libvirt] [PATCH 4/4] Misc error handling fixes in text mode monitor commands

Eric Blake eblake at redhat.com
Mon Nov 1 22:07:35 UTC 2010


On 11/01/2010 11:48 AM, Daniel P. Berrange wrote:
> A couple of places in the text monitor were overwriting the
> 'ret' variable with a >= 0 value before success was actually
> determined. So later error paths would not correctly return
> the -1 value. The drive_add code was not checking for errors
> like missing command
> 
> * src/qemu/qemu_monitor_text.c: Misc error handling fixes
> ---
>  src/qemu/qemu_monitor_text.c |   28 +++++++++++++++++++---------
>  1 files changed, 19 insertions(+), 9 deletions(-)

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20101101/c3aaa733/attachment-0001.sig>


More information about the libvir-list mailing list