[libvirt] [PATCH] tests: fix daemon-conf testing failure

Osier jyang at redhat.com
Tue Nov 2 14:47:53 UTC 2010


于 2010年11月02日 18:44, Daniel P. Berrange 写道:
> On Tue, Nov 02, 2010 at 05:11:22PM +0800, Osier Yang wrote:
>> libvirtd.conf uses "libvirt" as the value of "unix_sock_group",
>> however, group "libvirt" may not exist on system, in this case
>> the case will always be failed, which will cause 'make check'
>> , and 'make rpm' always be failed further more.
>>
>> As a solution, replace "libvirt" with "root" in "tmp.conf".
>>
>> * tests/daemon-conf
>> ---
>>   tests/daemon-conf |    3 +++
>>   1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/tests/daemon-conf b/tests/daemon-conf
>> index 6c91d96..225f84c 100755
>> --- a/tests/daemon-conf
>> +++ b/tests/daemon-conf
>> @@ -25,6 +25,9 @@ grep -v '\"PARAMETER = VALUE\"' "$conf" | grep '[a-z_]  *=  *[^ ]' | grep -vE '^
>>   # Start with the sample libvirtd.conf file, uncommenting all real directives.
>>   sed -n 's/^#\([^ #]\)/\1/p' "$conf">  tmp.conf
>>
>> +sed -e 's/^\(unix_sock_group =\).*/\1 "root"/g' tmp.conf>  k
>> +mv k tmp.conf
>> +
>>   # Iterate through that list of directives, corrupting one RHS at a
>>   # time and running libvirtd with the resulting config.  Each libvirtd
>>   # invocation must fail.
>
> Does this still work when running as non-root, or would it be better
> to subsitute in $USER ?

guess it will not, $USER is better. will update. thanks. :-)

- Osier
>
> Daniel




More information about the libvir-list mailing list