[libvirt] [PATCH] Allow virDomainGetMemoryParameters on read-only connections
Matthias Bolte
matthias.bolte at googlemail.com
Mon Nov 8 20:46:55 UTC 2010
2010/11/8 Daniel Veillard <veillard at redhat.com>:
> On Sun, Nov 07, 2010 at 01:38:22PM +0100, Matthias Bolte wrote:
>> Also fix a typo in the documentation of the function.
>> ---
>> src/libvirt.c | 6 +-----
>> 1 files changed, 1 insertions(+), 5 deletions(-)
>>
>> diff --git a/src/libvirt.c b/src/libvirt.c
>> index aebd3bc..2ffb2d9 100644
>> --- a/src/libvirt.c
>> +++ b/src/libvirt.c
>> @@ -3096,7 +3096,7 @@ error:
>> * }
>> *
>> * This function requires privileged access to the hypervisor. This function
>> - * expects the caller to allocate the @param
>> + * expects the caller to allocate the @params.
>> *
>> * Returns -1 in case of error, 0 in case of success.
>> */
>> @@ -3115,10 +3115,6 @@ virDomainGetMemoryParameters(virDomainPtr domain,
>> virDispatchError(NULL);
>> return -1;
>> }
>> - if (domain->conn->flags & VIR_CONNECT_RO) {
>> - virLibDomainError(domain, VIR_ERR_OPERATION_DENIED, __FUNCTION__);
>> - goto error;
>> - }
>> if ((nparams == NULL) || (*nparams < 0)) {
>> virLibDomainError(domain, VIR_ERR_INVALID_ARG, __FUNCTION__);
>> goto error;
>
> ACK,
>
> Daniel
Thanks, pushed.
Matthias
More information about the libvir-list
mailing list