[libvirt] [PATCH v2] show compiled in options in virsh --version
Daniel Veillard
veillard at redhat.com
Tue Nov 9 15:26:07 UTC 2010
On Tue, Nov 09, 2010 at 08:11:21AM -0700, Eric Blake wrote:
> On 11/09/2010 04:16 AM, Daniel Veillard wrote:
> >>> +++ b/tools/virsh.c
> >>> @@ -11525,6 +11525,7 @@ vshUsage(void)
> >>> " -t | --timing print timing information\n"
> >>> " -l | --log <file> output logging to file\n"
> >>> " -v | --version program version\n\n"
> >>> + " -V version and full options\n\n"
> >>
> >> In general, it's nice to have a long-option to go with every short
> >> option, but I don't think it's worth holding up this patch for just that.
> >>
> >> ACK.
> >
> > Thanks, pushed.
> >
> > I really think that -V was the right pick since it's the usual flag for
> > this kind of informations, but since -v/--version was already used I had
> > no idea how to name the long option, especially starting with letter
> > v...
>
> My earlier proposal was to make --version take an optional argument
> (only the long option form; the short options -v and -V have no argument):
>
> -v | --version[=short] program version
> -V | --version=long version and full options
>
> I can code that up, if you like the idea.
sure sounds fine to me, sorry I didn't remembered your suggestion !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel at veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
More information about the libvir-list
mailing list