[libvirt] [PATCH v2] macvtap: convert nl msg construction to use libnl

Stefan Berger stefanb at linux.vnet.ibm.com
Fri Nov 12 12:25:23 UTC 2010


On 11/12/2010 02:57 AM, Laine Stump wrote:
> On 11/04/2010 06:57 AM, Stefan Berger wrote:
>> V2:
>>    - forgot to convert two more function that were hidden in #defines
>>    - small nits
>>
>> In a first step I am converting the netlink message construction in 
>> macvtap code to use libnl. It's pretty much a 1:1 conversion except 
>> that now the message needs to be allocated and deallocated.
>>
>> Signed-off-by: Stefan Berger <stefanb at us.ibm.com>
>>
>> ---
>>  src/util/macvtap.c |  321 
>> ++++++++++++++++++++++-------------------------------
>>  1 file changed, 137 insertions(+), 184 deletions(-)
>
> ACK. This looks fine to me. I applied a non-corrupted version of the 
> patch to my local tree and it built with no problems on F13.

Great. I pushed it now.
Maybe you'll find something useful in it for the IPv6 work you are 
doing. The other patch of interest would be this one here:

https://www.redhat.com/archives/libvir-list/2010-November/msg00243.html

    Stefan




More information about the libvir-list mailing list