[libvirt] VMware Workstation/Player support

[Jean-Baptiste Rouault]

On Sunday 14 November 2010 23:11:22 Matthias Bolte wrote:
> 2010/11/12 Jean-Baptiste Rouault <jean-baptiste.rouault at diateam.net>:
> > On Tuesday 27 July 2010 20:42:01 Matthias Bolte wrote:
> >> We'll need to move the VMX handling code from src/esx to src/util,
> >> because drivers are not allowed to depend on each other.
> >> 
> >> That should be possible, but will require some refactoring, because
> >> this code is currently closely entangled with the reset of the ESX
> >> driver in some places and parts of it are probably quite ESX specific.
> > 
> > Hi,
> > 
> > As of today we have a "proof of concept" vmware driver with
> > basic functions implemented (open/close, define/undefine, create,
> > start/shutdown...)
> > However it currently depends on the esx driver for the VMX handling code.
> > Has anyone started to think of the needed refactoring ? If any help is
> > needed to refactor I guess I could find some time to work on it.
> > 
> > Jean-Baptiste
> 
> A while ago I started to refactor some obviously ESX specific stuff
> out of the VMX code into a callback mechanism.
> 
> One thing I'm going to change is the product version handling.
> 
> There should be no major problem left in the VMX code that could stop
> it from being moved to src/util/.
> 
> As you say you have some basic stuff working now, maybe it's a good
> idea that you show you code here for an initial review and let me do
> the refactoring once I can see how you use the VMX code.
> 
> Matthias

Here is the patch, I can try to split it if it's easier for the review.
The major part of this patch was done by an old colleague of mine,
there is still work and a bit of cleaning to do.

Regards,

Jean-Baptiste

-- 
Jean-Baptiste ROUAULT
Ingénieur R&D - Diateam : Architectes de l'information
Phone : +33 (0)9 53 16 02 70 Fax : +33 (0)2 98 050 051
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-VMware-Workstation-and-Player-driver.patch
Type: text/x-patch
Size: 61714 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20101115/3803f381/attachment-0001.bin>