[libvirt] [PATCH] RFC: Remove all object hashtable caches from virConnectPtr
Eric Blake
eblake at redhat.com
Mon Nov 15 18:27:56 UTC 2010
On 10/29/2010 05:52 AM, Daniel P. Berrange wrote:
> The virConnectPtr struct will cache instances of all other
> objects. APIs like virDomainLookupByUUID will return a
> cached object, so if you do virDomainLookupByUUID twice in
> a row, you'll get the same exact virDomainPtr instance.
Dave already ACK'd the design without looking through the code.
>
> * src/datatypes.h: Delete all hash tables.
> * src/datatypes.c: Remove all object caching code
> ---
> src/datatypes.c | 657
+++++++++++++------------------------------------------
> src/datatypes.h | 10 -
> 2 files changed, 149 insertions(+), 518 deletions(-)
I looked through this, and didn't see any obvious mistakes in the
deletion process, so:
ACK.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20101115/8fed58f0/attachment-0001.sig>
More information about the libvir-list
mailing list