[libvirt] [PATCH] nwfilter: use /bin/sh rather than requiring bash

Stefan Berger stefanb at linux.vnet.ibm.com
Tue Nov 16 11:30:23 UTC 2010


On 11/15/2010 09:54 PM, Eric Blake wrote:
> On 11/15/2010 07:18 PM, Stefan Berger wrote:
>>> I've gone ahead and pushed it.
>>>
>>
> diff --git i/src/nwfilter/nwfilter_ebiptables_driver.c
> w/src/nwfilter/nwfilter_ebiptables_driver.c
> index c3a0d3e..7b2a505 100644
> --- i/src/nwfilter/nwfilter_ebiptables_driver.c
> +++ w/src/nwfilter/nwfilter_ebiptables_driver.c
> @@ -61,7 +61,7 @@
>   #define CMD_DEF_PRE  "cmd='"
>   #define CMD_DEF_POST "'"
>   #define CMD_DEF(X) CMD_DEF_PRE X CMD_DEF_POST
> -#define CMD_EXEC   "eval res=\\$(\"${cmd}\")" CMD_SEPARATOR
> +#define CMD_EXEC   "eval res=\\$\\(\"${cmd}\"\\)" CMD_SEPARATOR
>   #define CMD_STOPONERR(X) \
>       X ? "if [ $? -ne 0 ]; then" \
>           "  echo \"Failure to execute command '${cmd}'.\";" \
>
>
ACK. Works for me and passes the TCK tests.

    Stefan





More information about the libvir-list mailing list