[libvirt] [PATCH v3] deprecate fclose() and introduce VIR_{FORCE_}FCLOSE()
Eric Blake
eblake at redhat.com
Tue Nov 16 15:37:08 UTC 2010
On 11/16/2010 04:50 AM, Stefan Berger wrote:
> V3:
> - fixes from V2 review + one lost hunk
>
> -> diff(tree+V2, tree+v3) at bottom of email
That helps. And you solved all my findings.
ACK.
> +++ src/xen/xen_driver.c 2010-11-16 06:31:49.722481846 -0500
> @@ -218,9 +218,9 @@
> #endif
> #ifdef __sun
> int fd;
>
> - if (fd = open("/dev/xen/domcaps", O_RDONLY)) {
> + if ((fd = open("/dev/xen/domcaps", O_RDONLY))>= 0) {
Did you want a space before >=?
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20101116/53027ea5/attachment-0001.sig>
More information about the libvir-list
mailing list