[libvirt] [PATCH 00/10] virCommand

Eric Blake eblake at redhat.com
Thu Nov 18 04:28:52 UTC 2010


This revives a couple of patch series from the past, and
rebases them on top of the current tree.  I've tested
that the daemon hook on SIGHUP works with this rewrite,
so I'm fairly confident that it is in decent shape, but
there's still a lot more to do for both converting
VIR_REALLOC_N to newer VIR_EXPAND_N or VIR_RESIZE_N, as
well as converting virExec uses to virCommand.

I wanted to get this posted for first reviews while I
continue porting more instances.

Daniel P. Berrange (5):
  Fix bug in setting up child stderr/out with /dev/null
  Remove bogus includes
  Introduce new APIs for spawning processes
  virCommand: docs for usage of new command APIs
  Port hooks and iptables code to new command execution APIs

Eric Blake (5):
  memory: make it safer to expand arrays
  memory: make it easier to avoid quadratic scaling of arrays
  daemon: use safer memory growth macros
  capabilities, cpu: use new array API
  maint: tighten strncmp syntax check

 .x-sc_avoid_write                 |    1 +
 .x-sc_prohibit_strcmp_and_strncmp |    9 -
 .x-sc_prohibit_strncmp            |    1 +
 HACKING                           |   59 ++-
 Makefile.am                       |    2 +-
 cfg.mk                            |   15 +-
 daemon/event.c                    |   44 +-
 daemon/libvirtd.c                 |    8 +-
 daemon/libvirtd.h                 |   11 +-
 docs/Makefile.am                  |   11 +-
 docs/hacking.html.in              |   64 ++-
 docs/internals.html.in            |    9 +
 docs/internals/command.html.in    |  491 +++++++++++++++++++
 docs/sitemap.html.in              |    4 +
 docs/subsite.xsl                  |   25 +
 po/POTFILES.in                    |    1 +
 src/Makefile.am                   |    1 +
 src/conf/capabilities.c           |   37 +-
 src/conf/capabilities.h           |   20 +-
 src/conf/cpu_conf.c               |    7 +-
 src/conf/cpu_conf.h               |    5 +-
 src/conf/domain_conf.c            |    1 -
 src/libvirt_private.syms          |   32 ++
 src/util/command.c                |  960 +++++++++++++++++++++++++++++++++++++
 src/util/command.h                |  213 ++++++++
 src/util/hooks.c                  |  217 +--------
 src/util/iptables.c               |   73 +---
 src/util/memory.c                 |   94 ++++-
 src/util/memory.h                 |   77 +++-
 src/util/util.c                   |    2 +-
 tests/.gitignore                  |    4 +
 tests/Makefile.am                 |   18 +-
 tests/commanddata/test10.log      |   14 +
 tests/commanddata/test11.log      |   14 +
 tests/commanddata/test12.log      |   12 +
 tests/commanddata/test13.log      |   12 +
 tests/commanddata/test14.log      |   12 +
 tests/commanddata/test15.log      |   12 +
 tests/commanddata/test2.log       |   12 +
 tests/commanddata/test3.log       |   14 +
 tests/commanddata/test4.log       |   12 +
 tests/commanddata/test5.log       |   10 +
 tests/commanddata/test6.log       |    6 +
 tests/commanddata/test7.log       |   11 +
 tests/commanddata/test8.log       |    7 +
 tests/commanddata/test9.log       |   18 +
 tests/commandhelper.c             |  136 ++++++
 tests/commandtest.c               |  572 ++++++++++++++++++++++
 tests/testutilsqemu.c             |    1 +
 49 files changed, 3009 insertions(+), 382 deletions(-)
 delete mode 100644 .x-sc_prohibit_strcmp_and_strncmp
 create mode 100644 .x-sc_prohibit_strncmp
 create mode 100644 docs/internals/command.html.in
 create mode 100644 docs/subsite.xsl
 create mode 100644 src/util/command.c
 create mode 100644 src/util/command.h
 create mode 100644 tests/commanddata/test10.log
 create mode 100644 tests/commanddata/test11.log
 create mode 100644 tests/commanddata/test12.log
 create mode 100644 tests/commanddata/test13.log
 create mode 100644 tests/commanddata/test14.log
 create mode 100644 tests/commanddata/test15.log
 create mode 100644 tests/commanddata/test2.log
 create mode 100644 tests/commanddata/test3.log
 create mode 100644 tests/commanddata/test4.log
 create mode 100644 tests/commanddata/test5.log
 create mode 100644 tests/commanddata/test6.log
 create mode 100644 tests/commanddata/test7.log
 create mode 100644 tests/commanddata/test8.log
 create mode 100644 tests/commanddata/test9.log
 create mode 100644 tests/commandhelper.c
 create mode 100644 tests/commandtest.c

-- 
1.7.3.2




More information about the libvir-list mailing list