[libvirt] [PATCH 1/4] Allow probing of image formats without version information

Adam Litke agl at us.ibm.com
Fri Nov 19 16:18:15 UTC 2010

Disk image formats that wish to opt-out of version validation are supposed to
set versionOffset to -1 in their fileTypeInfo entry.

By unconditionally returning False for these formats,
virStorageFileMatchesVersion() incorrectly reports a version mismatch when the
test was actually skipped.  The correct behavior is to return True so these
formats can be successfully probed using the magic bytes alone.

Signed-off-by: Adam Litke <agl at us.ibm.com>
 src/util/storage_file.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/util/storage_file.c b/src/util/storage_file.c
index 4098383..f8ab168 100644
--- a/src/util/storage_file.c
+++ b/src/util/storage_file.c
@@ -478,7 +478,7 @@ virStorageFileMatchesVersion(int format,
     /* Validate version number info */
     if (fileTypeInfo[format].versionOffset == -1)
-        return false;
+        return true;
     if ((fileTypeInfo[format].versionOffset + 4) > buflen)
         return false;

More information about the libvir-list mailing list