[libvirt] [PATCH 0/3] PHYP: Adding network management support

[Eduardo Otubo]

On 11/22/2010 12:52 PM, Daniel P. Berrange wrote:
> On Fri, Nov 19, 2010 at 12:55:03PM -0200, Eduardo Otubo wrote:
>> This is a series of 3 patches to add network management support for
>> pHyp driver.
>
> Can you explain what sort of network connectivity you are
> managing here ?
>
> The virNetwork APIs are specifically for an IP layer virtual
> switch, that does IP forwarding, optionally with NAT.
>
> Reading the patches, it sounds more like you're trying to
> represent ethernet layer virtual switches (aka bridging
> to physical NICs). This is what the virInterface APIs are
> intended to cover
>
> So if my understanding is correct you need to implement
> the virInterface APIs rather than virNetwork APIs

I guess you're right. My initial idea was to describe the management of 
network interfaces. I was not aware of this virInterface API. Perhaps I 
should re write from the beginning, which will not take long since I 
have all the command calls ready and logic fresh in my head.

Thanks you very much for the comment, will send a patch soon.

-- 
Eduardo Otubo
Software Engineer
Linux Technology Center
IBM Systems & Technology Group
Mobile: +55 19 8135 0885
eotubo at linux.vnet.ibm.com