[libvirt] [PATCH] Implementations of virDomainIsUpdated for drivers except qemu
Eric Blake
eblake at redhat.com
Wed Nov 24 18:33:01 UTC 2010
On 11/24/2010 12:43 AM, Osier Yang wrote:
> Except LXC and UML driver, implementations of all other drivers
> return 0 simpley, because these drivers doesn't have config both
s/return 0 simpley/simply return 0/
> in memory and on disk, no need to track if the domain of these
> drivers updated or not.
>
> Rename "xenUnifiedDomainisPersistent" to "xenUnifiedDomainIsPersistent"
Makes sense.
> +++ b/src/phyp/phyp_driver.c
> @@ -1277,6 +1277,11 @@ phypIsSecure(virConnectPtr conn ATTRIBUTE_UNUSED)
> return 1;
> }
>
> +static int
> +phypIsSecure(virConnectPtr conn ATTRIBUTE_UNUSED)
Too much copy-and-paste from the function above;
s/Secure(virConnect/Updated(virDomain/
> +++ b/src/uml/uml_driver.c
> @@ -1213,8 +1213,6 @@ cleanup:
> virDomainObjUnlock(obj);
> return ret;
> }
> -
> -
> static int umlDomainIsPersistent(virDomainPtr dom)
Spurious whitespace change.
ACK with the nits fixed, so I pushed the adjusted patch.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20101124/aa6b3143/attachment-0001.sig>
More information about the libvir-list
mailing list