[libvirt] [PATCH] doc: fix typo in virsh.pod

Osier Yang jyang at redhat.com
Wed Nov 3 03:12:28 UTC 2010


于 2010年11月03日 00:01, Eric Blake 写道:
> On 11/02/2010 04:18 AM, Osier Yang wrote:
>> ---
>>   tools/virsh.pod |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/virsh.pod b/tools/virsh.pod
>> index 5932aaa..f677383 100644
>> --- a/tools/virsh.pod
>> +++ b/tools/virsh.pod
>> @@ -301,7 +301,7 @@ L<http://libvirt.org/formatdomain.html#elementsCPU>
>>
>>   The following commands manipulate domains directly, as stated
>>   previously most commands take domain-id as the first parameter. The
>> -I<domain-id>  can be specified as an short integer, a name or a full UUID.
>> +I<domain-id>  can be specified as a short integer, a name or a full UUID.
>>
>>   =over 4
>>
>> @@ -326,7 +326,7 @@ If I<--console>  is requested, attach to the console after creation.
>>   B<Example>
>>
>>    virsh dumpxml<domain-id>  >  domain.xml
>> - edit domain.xml
>> + virsh edit domain.xml
>>    virsh create<  domain.xml
>
> NACK.  The whole point is that you are using your external editor here;
> that is:

urgh, didn't check it carefully, trusted QE. :-)

>
> virsh edit dom
>
> is shorthand for:
>
> virsh dumpxml dom>  domain.xml
> $EDITOR domain.xml
> virsh create<  domain.xml
> rm domain.xml
>
> However, a patch that changes 'edit' to $EDITOR would be welcome (and
> there's more than one instance that needs fixing; for example, see also
> net-edit).
>

however, this sentence is to tell editing the domain.xml, but not using 
"virsh *-edit", so $EDITOR will be meaningless here somehow. I could
use whatever I like to edit it, right? :-)

how about just to change it into:

- % virsh dumpxml dom > domain.xml
- edit domain.xml
- % virsh create < domain.xml

- Osier





More information about the libvir-list mailing list