[libvirt] [PATCH] [V2] tests: fix daemon-conf testing failure
Daniel Veillard
veillard at redhat.com
Wed Nov 3 10:44:25 UTC 2010
On Tue, Nov 02, 2010 at 10:54:12PM +0800, Osier Yang wrote:
> libvirtd.conf uses "libvirt" as the value of "unix_sock_group",
> however, group "libvirt" may not exist on system, in this case
> the case will always be failed.
>
> As a solution, replace "libvirt" with "root" in "tmp.conf".
>
> * tests/daemon-conf
> ---
> tests/daemon-conf | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/tests/daemon-conf b/tests/daemon-conf
> index 6c91d96..225f84c 100755
> --- a/tests/daemon-conf
> +++ b/tests/daemon-conf
> @@ -25,6 +25,9 @@ grep -v '\"PARAMETER = VALUE\"' "$conf" | grep '[a-z_] *= *[^ ]' | grep -vE '^
> # Start with the sample libvirtd.conf file, uncommenting all real directives.
> sed -n 's/^#\([^ #]\)/\1/p' "$conf" > tmp.conf
>
> +sed -e "s/^\(unix_sock_group =\).*/\1 \"$USER\"/g" tmp.conf > k
> +mv k tmp.conf
> +
> # Iterate through that list of directives, corrupting one RHS at a
> # time and running libvirtd with the resulting config. Each libvirtd
> # invocation must fail.
Okay ACK, pushed
thanks :-)
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel at veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
More information about the libvir-list
mailing list