[libvirt] [PATCH] configure: disable network and storage-fs drivers on mac os x

[Justin Clift]

On 10/05/2010 04:07 AM, Eric Blake wrote:
<snip>
> Hmm; the nested case $host seems odd to me. Maybe a better layout is:
>
> with_linux=no with_osx=no
> case $host in
> *-*-linux*) with_linux=yes ;;
> *-*-darwin*) with_osx=yes ;;
> esac
> if $with_linux = no; then
> if test "x$with_lxc" != xyes
> ...
> fi

Ahhh, that's a much better idea.  Will do. :)


>> AC_ARG_WITH([network],
>> AC_HELP_STRING([--with-network], [with virtual network driver
>> @<:@default=yes@:>@]),[],[with_network=yes])
>> -if test "$with_libvirtd" = "no" ; then
>> +
>> +dnl theres no use compiling the network driver without the libvirt
>
> s/theres/there's/

Oops.  Thanks. :)


>> +dnl daemon, nor compiling it for MacOS X, where it breaks the compile
>> +
>> +if test "$with_libvirtd" = "no" || test "$with_osx" = "yes"; then
>> with_network=no
>> fi
>
> Mostly looks okay, but probably worth a v2 to make sure the
> $host-detection case statement rewrite is still good.

No worries.  It'll be a tomorrow job though. :)