[libvirt] [PATCH] xen: Fix bogus error when attaching a device

Laine Stump laine at laine.org
Tue Oct 5 15:41:30 UTC 2010


>>>        default:
>>> -        xenXMError(VIR_ERR_XML_ERROR,
>>> -                   "%s", _("unknown device"));
>>> +        xenXMError(VIR_ERR_OPERATION_INVALID, "%s",
>>> +                   _("Xm driver only supports adding disk or network devices"));
>>>            goto cleanup;
>>>        }
>>>
>> It looks like many other similar errors in other drivers use
>> VIR_ERR_CONFIG_UNSUPPORTED. Would that maybe be a better choice than
>> VIR_ERR_OPERATION_INVALID
> Yeah, right, I guess it's not worth a v2, is it?

No. The new message is in any case better than the old, and there's not 
much that could be screwed up ;-). So ACK with the different error code.




More information about the libvir-list mailing list