[libvirt] [PATCH] Add the device alias element to the domain.rng schema
Eric Blake
eblake at redhat.com
Tue Oct 5 21:04:19 UTC 2010
On 10/04/2010 04:42 PM, Matthias Bolte wrote:
> Every device element that can contain an address element
> can also contain an alias element, but the domain.rng didn't
> reflect this. Therefore, running virt-xml-validate on the
> virsh dumpxml output of an active domain failed. It doesn't
> fail for inactive domains, because in that case dumpxml
> doesn't include the alias elements.
>
> Add the device alias element to the domain.rng schema and
> add a new test case to cover this.
>
> Indirectly reported by Jon Stanley.
> ---
> docs/schemas/domain.rng | 42 +++++++++++++++
> tests/domainschemadata/device-aliases.xml | 79 +++++++++++++++++++++++++++++
> 2 files changed, 121 insertions(+), 0 deletions(-)
What you have is correct. However, I'd also like to see the patch to
docs/formatdomain.html.in to document 'alias' before giving an ACK, to
get us in the habit of keeping documentation in sync.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
More information about the libvir-list
mailing list