[libvirt] [PATCH 1/4] xen: Make xenDaemon*DeviceFlags errors less confusing

[Eric Blake]

On 10/04/2010 05:47 AM, Jiri Denemark wrote:
>>
>> Should we always error out if _LIVE and inactive, or should we
>> special-case _CONFIG|_LIVE by silently ignoring the _LIVE flag on
>> inactive domains?
>
> Since there is the _CURRENT variant of the flag, erroring out if _LIVE and
> inactive seems like the right thing to do for me. One can always use _CONFIG |
> _CURRENT to change everything regardless on current state of the guest.
> Anyway, my patch is not aimed at solving the "to error out or not to error
> out" question but rather swapping two checks to get errors which are more
> logic. I think I should have used more context for the patch to make this
> clearer. Sorry about that.

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org