[libvirt] [PATCH 4/4] xen: Fix virDomain{At,De}tachDevice

[Eric Blake]

On 10/01/2010 02:09 PM, Jiri Denemark wrote:
> According to API documentation virDomain{At,De}tachDevice calls are
> supposed to only work on active guests for device hotplug. For anything
> beyond that, their *Flags variants have to be used.
>
> Despite the variant which was acked on libvirt mailing list
> (https://www.redhat.com/archives/libvir-list/2010-January/msg00385.html)
> commit ed9c14a7ef86d7a45a6d57cbfee5410fca428633 (by Jim Fehlig)
> introduced automagic behavior of these API calls for xen driver. Since
> January, these calls always change persistent configuration of a guest
> and if the guest is currently active, they also hot(un)plug the device.
>
> That change didn't follow API documentation and also broke device
> hot(un)plug for older xend implementations which do not support changing
> persistent configuration of a guest and hot(un)plugging in one step.
>
> This patch should not break anything for active guests. On the other
> hand, changing inactive guests is not supported any more.
> ---
>   src/xen/xen_driver.c |   24 ++++++++++++++++++------
>   1 files changed, 18 insertions(+), 6 deletions(-)

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org