[libvirt] [PATCH v3 04/13] XML parsing for memory tunables
Nikunj A. Dadhania
nikunj at linux.vnet.ibm.com
Fri Oct 8 08:52:59 UTC 2010
On Thu, 7 Oct 2010 12:48:26 +0100, "Daniel P. Berrange" <berrange at redhat.com> wrote:
> On Tue, Sep 28, 2010 at 03:26:30PM +0530, Nikunj A. Dadhania wrote:
> > From: Nikunj A. Dadhania <nikunj at linux.vnet.ibm.com>
> >
> > Adding parsing code for memory tunables in the domain xml file
> >
> > v2:
> > + Fix typo min_guarantee
> >
> > Signed-off-by: Nikunj A. Dadhania <nikunj at linux.vnet.ibm.com>
> > ---
> > src/conf/domain_conf.c | 50 +++++++++++++++++++++++++++++++++++++-------
> > src/conf/domain_conf.h | 12 ++++++++---
> > src/esx/esx_vmx.c | 30 +++++++++++++-------------
> > src/lxc/lxc_controller.c | 2 +-
> > src/lxc/lxc_driver.c | 12 +++++------
> > src/openvz/openvz_driver.c | 8 ++++---
> > src/qemu/qemu_conf.c | 8 ++++---
> > src/qemu/qemu_driver.c | 18 ++++++++--------
> > src/test/test_driver.c | 12 +++++------
> > src/uml/uml_conf.c | 2 +-
> > src/uml/uml_driver.c | 14 ++++++------
> > 11 files changed, 104 insertions(+), 64 deletions(-)
>
> ACK, looks fine, though it'd be good to add one or two
> example data files to tests/qemuxml2xmltest.c to ensure
> that we roundtrip through the XML parser+formatter
> correctly.
>
Sure, will add the files, and send the updated series
Nikunj
More information about the libvir-list
mailing list