[libvirt] [PATCH] util: add missing export

Eric Blake eblake at redhat.com
Tue Oct 12 14:27:22 UTC 2010


On 10/12/2010 08:23 AM, Matthias Bolte wrote:
>> --- a/src/libvirt_private.syms
>> +++ b/src/libvirt_private.syms
>> @@ -668,6 +668,7 @@ virFileResolveLink;
>>   saferead;
>>   safewrite;
>>   safezero;
>> +virHexToBin;
>>   virMacAddrCompare;
>>   virEnumFromString;
>>   virEnumToString;
>> --
>> 1.7.2.3
>>
>
> ACK.

Thanks; pushing shortly.

>
> How did you notice this?

For my vcpu patches, I was about to add virCountOneBits in util.c, and 
looked at how previous additions had done things.  Then it hit me - we 
already have gnulib's "count-one-bits.h", so I scrapped my new API, but 
kept the bug fix I had found on the way.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list