[libvirt] [PATCH 4/4] Fix symbol exports & remove duplicated libvirt_util.la linkage

Eric Blake eblake at redhat.com
Tue Oct 12 17:43:22 UTC 2010


On 10/12/2010 11:32 AM, Daniel P. Berrange wrote:
> @@ -708,6 +735,18 @@ virFileFindMountPoint;
>   virFileWaitForDevices;
>   virFileMatchesNameSuffix;
>   virArgvToString;
> +virStrcpy;
> +virStrncpy;
> +virBuildPathInternal;
> +virFileStripSuffix;
> +virFileOperation;
> +virFork;
> +virRandom;
> +virRandomInitialize;
> +virDirCreate;
> +virIndexToDiskName;
> +virHexToBin;

This is a duplicate with the patch I committed earlier today (I only 
noticed one function, but you obviously linked shard modules and found a 
lot more).  Should we be running this through sort | uniq -c and 
detecting any duplicate lines as part of 'make syntax-check'?

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list