[libvirt] [PATCH] Fix Xen SEXPR generation to properly quote strings containing ()
Eric Blake
eblake at redhat.com
Wed Oct 13 17:22:20 UTC 2010
On 10/13/2010 05:06 AM, Daniel P. Berrange wrote:
> * src/xen/sexpr.c: Ensure () are escaped in sexpr2string
> * tests/sexpr2xmldata/sexpr2xml-boot-grub.sexpr,
> tests/sexpr2xmldata/sexpr2xml-boot-grub.xml,
> tests/xml2sexprdata/xml2sexpr-boot-grub.sexpr,
> tests/xml2sexprdata/xml2sexpr-boot-grub.xml: Data files to
> check escaping
> * tests/sexpr2xmltest.c, tests/xml2sexprtest.c: Add boot-grub
> escaping test case
> ---
> src/xen/sexpr.c | 4 ++-
> tests/sexpr2xmldata/sexpr2xml-boot-grub.sexpr | 1 +
> tests/sexpr2xmldata/sexpr2xml-boot-grub.xml | 26 +++++++++++++++++++++++++
> tests/sexpr2xmltest.c | 2 +
> tests/xml2sexprdata/xml2sexpr-boot-grub.sexpr | 1 +
> tests/xml2sexprdata/xml2sexpr-boot-grub.xml | 21 ++++++++++++++++++++
> tests/xml2sexprtest.c | 2 +
> 7 files changed, 56 insertions(+), 1 deletions(-)
> create mode 100644 tests/sexpr2xmldata/sexpr2xml-boot-grub.sexpr
> create mode 100644 tests/sexpr2xmldata/sexpr2xml-boot-grub.xml
> create mode 100644 tests/xml2sexprdata/xml2sexpr-boot-grub.sexpr
> create mode 100644 tests/xml2sexprdata/xml2sexpr-boot-grub.xml
Hmm, I'm now seeing a 'make test' failure:
46) Xen XML-2-SEXPR boot-grub -> boot-grub ...
Expect [(hd0,0)/grub/menu.lst]
Actual ['(hd0,0)/grub/menu.lst']
... FAILED
FAIL: xml2sexprtest
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
More information about the libvir-list
mailing list