[libvirt] [PATCH] test: silence nwfilter test

[Stefan Berger]

  On 10/13/2010 06:07 PM, Eric Blake wrote:
> On 10/13/2010 02:37 PM, Stefan Berger wrote:
>> This patch silences the nwfilter test case.
>>
>> Signed-off-by: Stefan Berger <stefanb at us.ibm.com>
>>
>> ---
>> tests/nwfilterxml2xmltest.c | 120
>> +++++++++++++++++++++++++++-----------------
>> 1 file changed, 75 insertions(+), 45 deletions(-)
>
> ACK, with one nit fixed:
>
>> +
>> + if ((*log != '\0') != expect_warning) {
>
> Double-negative, but I don't know if this is any cleaner:
> if (!*log == expect_warning)
>
> so nothing to change on this line, after all.
>
>> +typedef struct test_parms {
>> + const char *name;
>> + bool expect_warning;
>
> Here, you have a bool,
>
>> + return testCompareXMLToXMLFiles(inxml, outxml, !!tp->expect_warning);
>
> So no need for !! to force conversion to a bool (you were just copying 
> from my qemuxml patch, though, where I was converting an int down to a 
> bool).  Just pass tp->expect_warning as-is.
>
Ok. Will fix it and push.

    Stefan