[libvirt] [PATCH] esx: Fix check in esxDomainGetInfo's perf metric handling
Matthias Bolte
matthias.bolte at googlemail.com
Sat Oct 16 10:11:12 UTC 2010
2010/10/15 Eric Blake <eblake at redhat.com>:
> On 10/15/2010 12:47 PM, Matthias Bolte wrote:
>>
>> ---
>> src/esx/esx_driver.c | 8 +++++---
>> 1 files changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c
>> index 8bc3be2..1b4ee29 100644
>> --- a/src/esx/esx_driver.c
>> +++ b/src/esx/esx_driver.c
>> @@ -2329,15 +2329,17 @@ esxDomainGetInfo(virDomainPtr domain,
>> virDomainInfoPtr info)
>> perfEntityMetric =
>>
>> esxVI_PerfEntityMetric_DynamicCast(perfEntityMetricBase);
>>
>> - if (perfMetricIntSeries == NULL) {
>> - VIR_ERROR0(_("QueryPerf returned object with
>> unexpected type"));
>> + if (perfEntityMetric == NULL) {
>> + VIR_ERROR(_("QueryPerf returned object with
>> unexpected type '%s'"),
>> +
>> esxVI_Type_ToString(perfEntityMetricBase->_type));
>> }
>>
>> perfMetricIntSeries =
>>
>> esxVI_PerfMetricIntSeries_DynamicCast(perfEntityMetric->value);
>
> ACK - looks like a copy-and-paste fix, in the category of "how did it ever
> possibly work when it was originally committed?".
>
Exactly :)
Thanks, pushed.
Matthias
More information about the libvir-list
mailing list