[libvirt] [PATCH v4] introduce VIR_CLOSE to be used rather than close()

[Eric Blake]

On 10/19/2010 08:08 AM, Stefan Berger wrote:
> There are lots of places where close() is being used. In this patch I am
> only cleaning up usage of close() in src/conf where the problems were.
>

ACK with a couple of nits:

> Index: libvirt-acl/src/conf/domain_conf.c
> ===================================================================
> --- libvirt-acl.orig/src/conf/domain_conf.c
> +++ libvirt-acl/src/conf/domain_conf.c
> @@ -44,8 +44,8 @@
> #include "network.h"
> #include "macvtap.h"
> #include "nwfilter_conf.h"
> -#include "ignore-value.h"

Don't delete this line, since ignore_value() is already in direct use in 
this file prior to the patch.

> + - eg close a file descriptor in an error path, without losing the
> previous
> + errno value
> +
> + VIR_FORCE_CLOSE(fd)

s/$/;/ (the html version got it right)

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org