[libvirt] [PATCH] virsh: consolidate memtune docs
Daniel Veillard
veillard at redhat.com
Tue Oct 19 16:10:42 UTC 2010
On Tue, Oct 19, 2010 at 09:38:05AM -0600, Eric Blake wrote:
> * tools/virsh.pod (memtune): Drop second copy, fill to 80 columns,
> enhance wording.
> ---
>
> Seeing memtune twice in the man page is a bit confusing.
ACK to the cleanup , I didn't realized it went to a different part ...
> This patch doesn't touch the pending issue of whether --min_guarantee
> makes sense, or should be deleted before it becomes a pre-mature
> API addition.
>
> Also, should memtune be changed to use VSH_OT_INT rather than
> VSH_OT_STRING? The current 'virsh help memtune' output looks
> weird:
>
> OPTIONS
> [--domain] <string> domain name, id or uuid
> --hard_limit <string> Max memory in kilobytes
> --soft_limit <string> Memory during contention in kilobytes
> --swap_hard_limit <string> Max swap in kilobytes
> --min_guarantee <string> Min guaranteed memory in kilobytes
hum, probably, yes :-)
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel at veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
More information about the libvir-list
mailing list