[libvirt] [PATCH 11/11] Add test suite for virSocket APIs
Eric Blake
eblake at redhat.com
Thu Oct 21 20:56:25 UTC 2010
On 10/21/2010 12:17 PM, Daniel P. Berrange wrote:
> Add a test suite for check parsing, formatting, range calculation
> and netmask checking APIs in virSocketAddr.
>
> * tests/sockettest.c, tests/Makefile.am: Add new test case
> ---
> tests/Makefile.am | 8 ++-
> tests/sockettest.c | 238 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 245 insertions(+), 1 deletions(-)
> create mode 100644 tests/sockettest.c
Nice addition.
> +++ b/tests/sockettest.c
> @@ -0,0 +1,238 @@
> +#include<config.h>
Missing a copyright disclaimer.
> +
> +static int
> +mymain(int argc ATTRIBUTE_UNUSED,
> + char **argv ATTRIBUTE_UNUSED)
> +{
> + int ret = 0;
> + /* Some of our tests delibrately test failure cases, so
s/delibrately/deliberately/
ACK with those nits fixed.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
More information about the libvir-list
mailing list