[libvirt] [PATCH] bye to close(), welcome to VIR_(FORCE_)CLOSE()
Stefan Berger
stefanb at us.ibm.com
Fri Oct 22 16:54:54 UTC 2010
libvir-list-bounces at redhat.com wrote on 10/22/2010 12:33:48 PM:
>
> On 10/22/2010 05:19 AM, Stefan Berger wrote:
> > Using automated replacement with sed and editing I have now replaced
all
> > occurrences of close() with VIR_(FORCE_)CLOSE() except for one, of
> > course. Some replacements were straight forward, others I needed to
pay
> > attention. I hope I payed attention in all the right places... Please
> > have a look. This should have at least solved one more double-close
> > error.
> >
> > Signed-off-by: Stefan Berger<stefanb at us.ibm.com>
>
> Pre-review comment:
> One more thing to do, which is adding something like this to cfg.mk:
>
> sc_avoid_close:
> @prohibit='\<close *\(' \
> in_vc_files='\.c$$' \
> halt='use VIR_(FORCE_)CLOSE instead of close' \
> $(_sc_search_regexp)
>
> along with adding .x-sc_avoid_close with contents of src/util/file.c to
> exempt the one valid use of close().
>
> Would you mind testing 'make syntax-check' after folding that in, and
> addressing any other fallout that it detects, while I proceed with the
> rest of my review?
Yes, I can do that... runs fine.
The patch will need to be rebased to tip...
Stefan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20101022/97b51777/attachment-0001.htm>
More information about the libvir-list
mailing list