[libvirt] [PATCH] Fix build for SystemTap 1.0

Eric Blake eblake at redhat.com
Fri Oct 22 23:23:29 UTC 2010


On 10/22/2010 05:08 PM, Matthias Bolte wrote:
> With SystemTap 1.0 a part of the generated macros in probes.h
> expands to:
>
> volatile __typeof__(((name))) arg2 = (name);
>
> GCC reports an 'invalid initialize' error when name has type
> char[]. Therfore, add casts to char* to avoid this.
> ---
>   daemon/libvirtd.c |    4 ++--
>   daemon/remote.c   |    4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
> index 8e88d05..d3f003e 100644
> --- a/daemon/libvirtd.c
> +++ b/daemon/libvirtd.c
> @@ -1230,11 +1230,11 @@ remoteCheckCertificate(struct qemud_client *client)
>           }
>       }
>
> -    PROBE(CLIENT_TLS_ALLOW, "fd=%d, name=%s", client->fd, name);
> +    PROBE(CLIENT_TLS_ALLOW, "fd=%d, name=%s", client->fd, (char *)name);

Looks gross, but it doesn't affect too many probes, and expands the 
range of versions we support.

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list