[libvirt] [PATCH] [TCK] network: create networks and check for exected results

Stefan Berger stefanb at linux.vnet.ibm.com
Tue Oct 26 23:27:43 UTC 2010


  On 10/26/2010 07:08 PM, Eric Blake wrote:
>
> Sorry for sounding so depressing; I'm very pleased to see your efforts 
> in providing tests for the code you've written.  Even though this test 
> is intended to be skipped on non-Linux, you still have to worry about 
> merely parsing through the test on other platforms like Solaris, where 
> /bin/sh won't understand the bash-isms and where /bin/bash is not 
> guaranteed to exist.  But if we decide that requiring the presence of 
> /bin/bash is acceptable for the TCK, then a lot of my review becomes 
> irrelevant; but my comments about your mkstemp replacement being 
> insecure are still applicable even in that case.
>
Ok. Well, I hope for bash then...

    Stefan




More information about the libvir-list mailing list