[libvirt] [PATCH] qemu: check for vm after starting a job
Daniel Veillard
veillard at redhat.com
Wed Oct 27 13:54:07 UTC 2010
On Tue, Oct 26, 2010 at 05:32:09PM -0600, Eric Blake wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=638285 - when migrating
> a guest, it was very easy to provoke a race where an application
> could query block information on a VM that had just been migrated
> away. Any time qemu code obtains a job lock, it must also check
> that the VM was not taken down in the time where it was waiting
> for the lock.
>
> * src/qemu/qemu_driver.c (qemudDomainSetMemory)
> (qemudDomainGetInfo, qemuDomainGetBlockInfo): Check that vm still
> exists after obtaining job lock, before starting monitor action.
[...]
> if (err < 0) {
> + endjob:
> if (qemuDomainObjEndJob(vm) == 0)
[...]
>
> + endjob:
> if (qemuDomainObjEndJob(vm) == 0)
Looks fine to me but it seems there is some indentation issues
just check those before commit,
ACK
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel at veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
More information about the libvir-list
mailing list