[libvirt] [PATCH 4/7] network: use virAsprintf when appropriate

Eric Blake eblake at redhat.com
Wed Sep 1 23:01:13 UTC 2010


On 09/01/2010 03:20 PM, Matthias Bolte wrote:
> 2010/9/1 Eric Blake<eblake at redhat.com>:
>> * src/conf/network_conf.c (virNetworkAllocateBridge): Avoid
>> limited buffer from snprintf.
>> ---
>>
>> Why print to a fixed-width buffer to then just strdup it later,
>> when we can print to a malloc'd buffer in the first place.  Besides,
>> I couldn't easily guarantee if the buffer was large enough or if
>> it would contain arbitrary user input.
>>
>
> ACK.

Thanks; pushed.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list