[libvirt] [PATCH] esx: Fix generator for string return values

Matthias Bolte matthias.bolte at googlemail.com
Thu Sep 2 10:58:28 UTC 2010


2010/9/1 Eric Blake <eblake at redhat.com>:
> On 09/01/2010 09:32 AM, Matthias Bolte wrote:
>>
>> That's a bit tricky. In case Parameter.get_type_string() is called
>> from Parameter.generate_return() then
>>
>>   string += "%s*%s)%s" % (self.get_type_string(), self.name, end_of_line)
>>
>> in line 104 adds the second *.
>>
>> I attached v2 where this is simplified.
>
> Yes, it's much easier to see in v2.  ACK, if you trust my minimal python
> reviewing skills.
>

Well, your first review already improved the patch :)

Thanks, pushed v2.

Matthias




More information about the libvir-list mailing list