[libvirt] [PATCH] esx: Use SessionIsActive when available

Matthias Bolte matthias.bolte at googlemail.com
Tue Sep 7 22:34:37 UTC 2010


2010/9/6 Daniel Veillard <veillard at redhat.com>:
> On Sun, Sep 05, 2010 at 11:41:39PM +0200, Matthias Bolte wrote:
>> ---
>>  src/esx/esx_vi.c |  122 +++++++++++++++++++++++++++---------------------------
>>  src/esx/esx_vi.h |    1 +
>>  2 files changed, 62 insertions(+), 61 deletions(-)
>
>  Looks like information is available at runtime, so that sounds the
> right way. But a bit of details in the commit log would be nice the
> old code was just statically compiling it off right ?
>
> ACK
>
> Daniel
>

True, this deserves a more verbose commit message. I added this and
pushed the result:

    Before this commit SessionIsActive was not used because ESX(i)
    doesn't implement it. vCenter supports SessionIsActive, so use
    it here, but keep the fall back mechanism for ESX(i) and GSX

Matthias




More information about the libvir-list mailing list